Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esbuild): transpile with esnext in dev #10207

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 23, 2022

Description

Fix #10167

In dev transpiling ts/tsx (etc) and vue (with lang="ts"), set esbuild target to esnext to prevent syntax lowering. This should only affect dev, as build runs another round of transpile based on build.target.

Additional context

Thanks @sapphi-red for digging into this.

Given that this used to work in the past, I think this isn't a breaking change.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p4-important Violate documented behavior or significantly improves performance (priority) label Sep 23, 2022
@bluwy bluwy changed the title fix(esbuild): transpile with esnext fix(esbuild): transpile with esnext in dev Sep 23, 2022
@patak-dev
Copy link
Member

@bluwy would you also backport to the v3.1 branch? I think it would be good to fix it there too.

@patak-dev patak-dev merged commit 43b7b78 into main Sep 23, 2022
@patak-dev patak-dev deleted the fix-transpile-esnext branch September 23, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tsconfig target is not ignored for both dev and build
2 participants